feat: Handle redirection status #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added WebSocket routing and interception functionality.
Ishita-Jinturkar
changed the title
Ishita-Jinturkar
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved handling for WebSocket connections in the
cdp_use/client.pymodule, specifically adding support for HTTP redirects and authentication errors during WebSocket connection establishment. The changes also lay groundwork for future WebSocket routing/interception features.WebSocket connection improvements
_connect_with_redirectsasync function to handle HTTP redirects (301, 302, 307, 308) and authentication errors (401, 403) when establishing a WebSocket connection. This function follows redirects and raises descriptive errors as needed. (cdp_use/client.py)startmethod to use_connect_with_redirectsinstead of the directwebsockets.connectcall, ensuring redirect and authentication handling is applied during connection setup. (cdp_use/client.py)Issue link: browser-use/browser-use#3073